Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammatical and typo corrections #477

Closed
wants to merge 3 commits into from

Conversation

mdqst
Copy link

@mdqst mdqst commented Nov 9, 2024

Description:

Added grammatical and typo corrections to documentation for the following files:

  • docs/03_register.md
  • docs/04_voting.md
  • docs/06_maci_troubleshooting.md

Goal

Correct grammatical errors and improve readability of the documentation.

Copy link

vercel bot commented Nov 9, 2024

@mdqst is attempting to deploy a commit to the Privacy and Scaling Explorations Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Nov 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maci-platform ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 11:00am

Copy link
Contributor

@kittybest kittybest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! please fix the commit message

@ctrlc03
Copy link
Collaborator

ctrlc03 commented Dec 6, 2024

mdqst added 3 commits December 6, 2024 10:51
Typo and awkward phrasing: It should be "wearing a hat with a certain ID."
Corrected version: "Those who are wearing a hat with a certain ID could register."

Corrected.
"could" is incorrect here; it should be "can" for consistency and clarity.

Corrected.
"already used to registered before"

Grammar: The phrase "used to registered" should be "used to register."
Corrected version: "The provided attestation is already used to register before."

Corrected.
@ctrlc03
Copy link
Collaborator

ctrlc03 commented Dec 23, 2024

While we appreciate you submitting this PR, we will be closing it to conform with our updated contributions guidelines https://maci.pse.dev/docs/contributing/ - cited: "We do not accept minor grammatical fixes (e.g., correcting typos, rewording sentences) unless they significantly improve clarity in technical documentation". We hope you see you contribute to the project, if in search for a task to take, please refer to our open issues, or contact the team.

@ctrlc03 ctrlc03 closed this Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants